Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sai_redis_interface_query] Add sairedis support for sai_query_attribute_enum_values_capability #525

Merged
merged 4 commits into from
Oct 28, 2019
Merged

[sai_redis_interface_query] Add sairedis support for sai_query_attribute_enum_values_capability #525

merged 4 commits into from
Oct 28, 2019

Conversation

daall
Copy link
Contributor

@daall daall commented Oct 24, 2019

[sai_redis_interface_query] Add sairedis support for sai_query_attribute_enum_values_capability

  • Add sai_query_attribute_enum_values_capability to libsairedis
  • Add handler for sai_query_attribute_enum_values_capability to syncd
  • Add sai_query_attribute_enum_values_capability implementation to virtual switch

Signed-off-by: Danny Allen [email protected]

Depends on: sonic-net/sonic-swss-common#313

@daall
[sai_redis_interface_query] Add sairedis support for sai_query_attrib…
6b27b85 
…ute_enum_values_capability

* Add sai_query_attribute_enum_values_capability to libsairedis
* Add handler for sai_query_attribute_enum_values_capability to syncd
* Add sai_query_attribute_enum_values_capability implementation to virtual switch

Signed-off-by: Danny Allen <[email protected]>
@daall daall requested review from wendani and kcudnik October 24, 2019 02:09
@daall daall self-assigned this Oct 24, 2019
@daall daall mentioned this pull request Oct 24, 2019
Merged
kcudnik
kcudnik reviewed Oct 24, 2019
View reviewed changes
syncd/syncd.cpp Outdated Show resolved Hide resolved
@daall daall requested a review from lguohan October 25, 2019 17:40
@daall
Copy link
Contributor Author

daall commented Oct 25, 2019

Opened #526 and #527 to track testing/debugging improvements for these new query APIs.

@daall daall mentioned this pull request Oct 25, 2019
Merged
@lguohan lguohan merged commit ff5306e into sonic-net:master Oct 28, 2019
@Walker917
Copy link

Walker917 commented Nov 26, 2019 •
edited
Loading

i got a error when i build sonic-buildimage
make init
make configure PLATFORM=centec
make all
./syncd/syncd.cpp:2969: undefined reference to `sai_object_type_get_availability'

syncd-syncd.o: In function processObjectTypeGetAvailabilityQuery(std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::vector<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > > const&)': ./syncd/syncd.cpp:2969: undefined reference to sai_object_type_get_availability'

@wendani
Copy link
Contributor

wendani commented Apr 19, 2020

What is the purpose of having this support?

pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
@daall @lguohan
[sai_redis_interface_query] Add sairedis support for sai_query_attrib…
9eca62e 
…ute_enum_values_capability (sonic-net#525)

* [sai_redis_interface_query] Add sairedis support for sai_query_attribute_enum_values_capability
* Add sai_query_attribute_enum_values_capability to libsairedis
* Add handler for sai_query_attribute_enum_values_capability to syncd
* Add sai_query_attribute_enum_values_capability implementation to virtual switch

Signed-off-by: Danny Allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcudnik kcudnik kcudnik approved these changes

@wendani wendani Awaiting requested review from wendani

@lguohan lguohan Awaiting requested review from lguohan

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

Assignees

@daall daall

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daall @Walker917 @wendani @kcudnik @lguohan